Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update p5.Vector references #6848

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

nickmcintyre
Copy link
Member

Preparing references in src/math/p5.Vector.js for the new website.

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated

@Qianqianye @davepagurek @limzykenneth

@@ -2355,35 +3101,60 @@ p5.Vector = class {
// Static Methods

/**
* Make a new 2D vector from an angle.
* Create a new 2D vector from an angle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "creates" to have consistent tense with the others above (e.g. "returns ....")

@Qianqianye
Copy link
Contributor

Thanks @nickmcintyre and @davepagurek. I updated the three 'create' to 'creates' for consistent tense.
This is a similar comment to the one in #6849.

In the new website, will the p5.Vector methods (like copy(), rotate() ) stay inside the p5.Vector reference page or to the main Reference page? If it stays inside the p5.Vector reference page, will the page layout (a list with long description) stays the same? Not sure if this is included in the upcoming 'Reorganize the Reference group/categorization and order' task.

We are aware that the following naming convention could be confusing:

CC @limzykenneth @davepagurek

@Qianqianye Qianqianye merged commit b2f9d4a into processing:main Mar 14, 2024
2 checks passed
@nickmcintyre nickmcintyre deleted the ref-p5-vector branch May 6, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants