Update image references #6863
Merged
Update image references #6863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qianqianye
reviewed
Mar 15, 2024
src/image/image.js
Outdated
| @@ -457,27 +556,37 @@ p5.prototype.encodeAndDownloadGif = function(pImg, filename) { | |||
| }; | |||
|
|
|||
| /** | |||
| * Captures a sequence of frames from the canvas that can be used to create a | |||
| * movie. Frames are downloaded as individual image files by default. | |||
| * Creates an array of frames from the canvas that can be saved as images. | |||
There was a problem hiding this comment.
How about 'Saves a sequence of frames from the canvas' or 'Captures a sequence of frames from the canvas'?
What do you think, @davepagurek ?
There was a problem hiding this comment.
"Captures" sounds good to me! (we have "saved" later in the sentence so "captures" avoids duplication)
There was a problem hiding this comment.
Sounds good, updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing references in
src/image/image.jsfor the new website.PR Checklist
npm run lintpasses@Qianqianye @limzykenneth @davepagurek