Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[p5.js - es] Translate contributing_to_the_p5.js_reference #6871

Merged
merged 7 commits into from
Mar 18, 2024
Merged

[p5.js - es] Translate contributing_to_the_p5.js_reference #6871

merged 7 commits into from
Mar 18, 2024

Conversation

ninioArtillero
Copy link
Contributor

Changes: Spanish translation of documentation

@welcome Welcome
Copy link

welcome bot commented Mar 15, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@ninioArtillero ninioArtillero force-pushed the es-translation-contributing-to-reference branch from c86463d to 0bb6856 Compare March 15, 2024 22:06
holomorfo
holomorfo reviewed Mar 17, 2024
View reviewed changes
contributor_docs/es/contributing_to_the_p5.js_reference.md Outdated
@@ -0,0 +1,529 @@
# Contributing to the p5.js Reference
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @ninioArtillero entiendo que aun no esta listo para revision verdad? veo fragmentos todavia en progreso

Copy link
Contributor Author

@ninioArtillero ninioArtillero Mar 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya está listo para revisión; dejé el texto original en inglés junto a su traducción para facilitarla. @holomorfo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si prefieres puedo quitar de una vez todo el texto original en inglés para que quede en su forma final (salvo correcciones). @holomorfo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya lo deje en limpio

@ninioArtillero
Copy link
Contributor Author

Nota: Estructuré los commits para facilitar la revisión

holomorfo
holomorfo approved these changes Mar 18, 2024
View reviewed changes
Copy link

@holomorfo holomorfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente trabajo Xavier, muchas gracias, aprobado.
Esto concluye tu trabajo para este primer bloque cierto?
CC: @Guirdo

@ninioArtillero
Copy link
Contributor Author

Excelente trabajo Xavier, muchas gracias, aprobado. Esto concluye tu trabajo para este primer bloque cierto? CC: @Guirdo

Gracias @holomorfo ; en efecto este documento es lo que me corresponde para este bloque.

@Guirdo Guirdo self-assigned this Mar 18, 2024
@Guirdo
Copy link
Contributor

Guirdo commented Mar 18, 2024

Muchas gracias Xavier! Aprovado! 👍

@Guirdo
Copy link
Contributor

Guirdo commented Mar 18, 2024

Hello @Qianqianye and @limzykenneth ! @holomorfo and I have approved this PR.

@ninioArtillero ninioArtillero marked this pull request as ready for review March 18, 2024 16:58
@Qianqianye Qianqianye merged commit 4cf03de into processing:main Mar 18, 2024
2 checks passed
@Qianqianye
Copy link
Contributor

Looks great, thanks @ninioArtillero @Guirdo @holomorfo!

@Qianqianye Qianqianye added the Translation Translation of p5.js documentation label Mar 18, 2024
@ninioArtillero ninioArtillero changed the title spanish translation of contributing_to_p5.js_reference.md [p5.js - es] Translate contributing_to_p5.js_reference Mar 19, 2024
@ninioArtillero ninioArtillero changed the title [p5.js - es] Translate contributing_to_p5.js_reference [p5.js - es] Translate contributing_to_the_p5.js_reference Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holomorfo holomorfo holomorfo approved these changes

Assignees

@Guirdo Guirdo

Labels
Translation Translation of p5.js documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ninioArtillero @Guirdo @Qianqianye @holomorfo