-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[p5.js - zh] Update steward_guidelines.md #6879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit the text after "#### test Task".
unicar9
reviewed
Mar 17, 2024
sproutleaf
suggested changes
Mar 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
谢谢!
Harrycheng233
changed the title
Update steward_guidelines.md
[p5.js - zh] Update steward_guidelines.md
Mar 18, 2024
unicar9
reviewed
Mar 19, 2024
unicar9
reviewed
Mar 19, 2024
sproutleaf
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
谢谢+辛苦了!
unicar9
approved these changes
Mar 19, 2024
Hi @Qianqianye and @limzykenneth, this PR can be merged, thanks :) |
Qianqianye
reviewed
Mar 19, 2024
Thanks @Harrycheng233 @unicar9 @sproutleaf 💓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit the text after "#### test Task".
Resolves #[Add issue number here]
Changes:
Edited the text after "#### test Task"
Screenshots of the change:
PR Checklist
npm run lint
passes