fixed parameters for normal() method #6984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6982
Changes:
It seems that in
src\core\shape\vertex.js
for thenormal()
method the documentation was written as@param {Vector} vector
and sinceVector
isn't a native JS class when the FES couldn't useinstanceOf
to check andtypeOf
checked the e.g. examplelet n = createVector(-0.4, -0.4, 0.8);
which would return object since Vector is not a native JS class.A quick and easy fix would be to change
@param {Vector} vector
to@param {p5.Vector} vector
so FES can correctly check the parameter.Screenshots of the change:
PR Checklist
npm run lint
passes