Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main canvas clipping getting applied to framebuffers #6990

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix main canvas clipping getting applied to framebuffers #6990

merged 1 commit into from
Apr 24, 2024

Conversation

davepagurek
Copy link
Contributor

Resolves #6989

Changes:

  • Makes sure the WebGL stencil check, which is what applies the clipping, is updated both when you start drawing to a framebuffer as well as when you stop (previously, it only did this when you stop)

Screenshots of the change:

The code in the issue now produces a red canvas in Chrome as expected:
image

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

@Qianqianye Qianqianye merged commit 4ba6ffc into processing:main Apr 24, 2024
2 checks passed
@yamcodes yamcodes mentioned this pull request Jun 12, 2024
Open
@saurabhpro saurabhpro mentioned this pull request Jul 12, 2024
Open
@yamcodes yamcodes mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beginClip() is accidentally being applied to framebuffers
2 participants
@davepagurek @Qianqianye