-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch camera keep transform #7067
Merged
Qianqianye
merged 36 commits into
processing:main
from
davepagurek:switch-camera-keep-transform
May 25, 2024
Merged
Switch camera keep transform #7067
Qianqianye
merged 36 commits into
processing:main
from
davepagurek:switch-camera-keep-transform
May 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Since #6761 is merged, are we ready to merge this one @davepagurek? Thanks! |
this is good to go now too, yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7056 (but don't merge this until after #6761 is merged!)
Changes
This branches off of #6761, which is ready to merge, but will be merged after our final docs release today so that we have time to beta test more thoroughly before doing a release. In the mean time, the actual diff can be seen here: deveshidwivedi/p5.js@model-view...davepagurek:p5.js:switch-camera-keep-transform
But to summarize:
setCamera
updates the view matrix in addition to the projection matrixcamera()
no longer resets the model matrix, just the view matrixNow, a
resetMatrix()
is no longer required after usingsetCamera
in a framebuffer'sbegin
/end
: https://editor.p5js.org/davepagurek/sketches/k71F1YPDpPR Checklist
npm run lint
passes