Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #7084

Closed
wants to merge 2 commits into from
Closed

Conversation

Manancode
Copy link

resolves issue #7083 . Fixing all broken links in the documentation

Copy link

welcome bot commented Jun 3, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

[`_validateParameters()`]: https://github.com/processing/p5.js/blob/main/contributor_docs/fes_reference_dev_notes.md#validateparameters
[`_fesErrorMontitor()`]: https://github.com/processing/p5.js/blob/main/contributor_docs/fes_reference_dev_notes.md#feserrormonitor
[Dev Notes]: https://github.com/processing/p5.js/blob/main/contributor_docs/fes_reference_dev_notes.md
[`_friendlyFileLoadError()`]: https://github.com/processing/p5.js/blob/daba49806a389e98cd63c62667928f61243c7fa1/contributor_docs/fes_contribution_guide.md#_friendlyerror
Copy link
Contributor

@Qianqianye Qianqianye Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Qianqianye Qianqianye requested a review from limzykenneth June 3, 2024 22:57
@limzykenneth
Copy link
Member

I'd prefer not linking to a specific commit otherwise if we were to make updates to those documentation, these links will need to be updated again.

@Gautam-aman
Copy link

Can i also woek in this issue??

@limzykenneth
Copy link
Member

@Gautam-aman #7117 will fix this so we don't need additional fixes for the linked issue for now. Do have a look at other open issues. Thanks.

@Qianqianye
Copy link
Contributor

This is resolved in #7117. Thank you all!
@all-contributors please add @Manancode for documentation

@Qianqianye Qianqianye closed this Jul 24, 2024
Copy link
Contributor

@Qianqianye

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token { in JSON at position 168759

@Qianqianye
Copy link
Contributor

@all-contributors please add @Manancode for documentation

Copy link
Contributor

@Qianqianye

I've put up a pull request to add @Manancode! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants