Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds webp mime type to saveCanvas. #7140

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

starzonmyarmz
Copy link
Contributor

Updates source code to properly support webp format. Refs processing/p5.js-website#451.

Copy link

welcome bot commented Jul 19, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

Copy link
Member

@nickmcintyre nickmcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start @starzonmyarmz! Would you please also add 'wepb' to the main reference text on line 165?

@starzonmyarmz
Copy link
Contributor Author

Thanks @nickmcintyre. Fixed in bec4f75.

Copy link
Member

@nickmcintyre nickmcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me–thanks @starzonmyarmz!

@Qianqianye Qianqianye merged commit 5c87036 into processing:main Jul 22, 2024
2 checks passed
@Qianqianye
Copy link
Contributor

Thank you both!
@all-contributors please add @starzonmyarmz for documentation

Copy link
Contributor

@Qianqianye

I've put up a pull request to add @starzonmyarmz! 🎉

@starzonmyarmz starzonmyarmz deleted the support-webp-mime-type branch July 22, 2024 20:00
@starzonmyarmz starzonmyarmz restored the support-webp-mime-type branch July 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants