Fix unnecessary console warnings when using smooth() on P2D Graphics objects #7159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Changed
smooth
implementation to matchnoSmooth
.Previously
smooth
would callsetAttributes
regardless of whether or not the renderer is P2D or WebGL, on Graphics objects (to my knowledge, maybe on others too) when the renderer is P2D, this would cause unnecessary logs complaining aboutsetAttributes
's use.I have changed the
smooth
function to callsetAttributes
only if the renderer is WebGL.I have not tested this extensively (I have though tested this change on one of my own projects using p5.js in which it functions perfectly fine),
but for such a minor change that takes from existing code I feel that it should work fine in all scenarios.
However feel free to close this pull request if there is a specific reason that the smooth function must be programmed this way
PR Checklist
npm run lint
passes