Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #7181 #7182

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix for #7181 #7182

merged 1 commit into from
Aug 16, 2024

Conversation

orrkislev
Copy link
Contributor

resolves #7181

Changes:
moved class="norender" from code to div, in documentation of print() and position()

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

Copy link

welcome bot commented Aug 16, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@davepagurek
Copy link
Contributor

davepagurek commented Aug 16, 2024

Thanks for fixing these here! Every new release, the content in the reference files gets automatically updated from the multiline doc comments in the main p5.js repo, so in order to fix this and keep it fixed, we'll need to make the change there too. Would you be willing to open a PR there for that?

Edit: I mistook this for the website repo, this is in fact in the right spot!

@davepagurek davepagurek merged commit 12fb773 into processing:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<code class="norender"> shows in the reference code snippets and break execution
2 participants