Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added WEBGL mode for correct blendMode(SUBTRACT) behavior #7229

Merged
merged 6 commits into from
Sep 9, 2024
Merged

fix: added WEBGL mode for correct blendMode(SUBTRACT) behavior #7229

merged 6 commits into from
Sep 9, 2024

Conversation

Abhinavcode13
Copy link
Contributor

Resolves - #7217

davepagurek
davepagurek reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these fixes! Just one request on the comments, since users won't have the context of a prior 2D mode version.

src/core/rendering.js Outdated Show resolved Hide resolved
@Abhinavcode13
Copy link
Contributor Author

gentle ping - @davepagurek

davepagurek
davepagurek approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@davepagurek davepagurek merged commit 67f7be6 into processing:main Sep 9, 2024
2 checks passed
@davepagurek
Copy link
Contributor

@all-contributors please add @Abhinavcode13 for docs

@allcontributors AllContributors
Copy link
Contributor

@davepagurek

@Abhinavcode13 already contributed before to doc

@Abhinavcode13 Abhinavcode13 deleted the patch-1 branch September 10, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepagurek davepagurek davepagurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhinavcode13 @davepagurek