Performance improvements for WebGL shape drawing #7287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7237
This makes two changes:
=
was an===
so it wasn't being applied, oops 😬I tested with this https://editor.p5js.org/davepagurek/sketches/vmiMgGi5s which makes a new geometry and draws it each frame. The perf I got was:
Chrome
Firefox
I didn't make the other change requested in the issue to make
buildGeometry
update the line vertex data when you add a new shape. This is because when we add it, we have to transform every vertex anyway. This is probably not less work than just recreating it, and if you do any other operation (e.g. add this geometry into another geometry), you'd be doing more work overall by transforming twice.PR Checklist
npm run lint
passes