Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mouseY reference first example issue fixed #7311

Merged
merged 1 commit into from
Oct 23, 2024
Merged

mouseY reference first example issue fixed #7311

merged 1 commit into from
Oct 23, 2024
+1 −1

Conversation

shourysingh07
Copy link
Contributor

Resolves issue #583 of p5.js website repo.

Changes:

  • Added a horizontal black line that moves up and down following the mouse's Y-position in the first example for mouseY, where it was previously missing.

Screenshots of the change:

Before:

before.mp4

After:

after.mp4

@shourysingh07 shourysingh07 mentioned this pull request Oct 13, 2024
Open
perminder-17
perminder-17 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Thanks for the fix. :)

@davepagurek davepagurek merged commit 711869b into processing:main Oct 23, 2024
2 checks passed
@shourysingh07 shourysingh07 deleted the issue_583 branch October 24, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perminder-17 perminder-17 perminder-17 approved these changes

@davepagurek davepagurek Awaiting requested review from davepagurek

@Qianqianye Qianqianye Awaiting requested review from Qianqianye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shourysingh07 @perminder-17 @davepagurek