Handle return-type of HeaderCollection->get() #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneBruines
force-pushed
the
feature-header-collection
branch
from
971cf6b to
49d4cfd
Compare
EtienneBruines
force-pushed
the
feature-header-collection
branch
from
49d4cfd to
76aa3bb
Compare
akondas
approved these changes
Sep 10, 2019
|
If ok, then we can merge and release |
ghost
approved these changes
Sep 12, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior does not distinguish between
string[]orstring; this PR covers some common use-cases.Also added three test-cases in the controller, which fail without the new extension, because
phpstanwas unable to detect the return type.