Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for image pull secrets for Ray Cluster images #162

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Add support for image pull secrets for Ray Cluster images #162

merged 3 commits into from
Jun 29, 2023

Conversation

VanillaSpoon
Copy link
Contributor

@VanillaSpoon VanillaSpoon commented Jun 16, 2023 •
edited
Loading

Fixes #147

This pr adds the configuration to supply zero or more image pull secrets within the pod specification. Enabling access to private image registries.

imagePullSecrets:
 -name: <image-pull-secret>

VanillaSpoon
VanillaSpoon commented Jun 16, 2023
View reviewed changes
tests/test-case.yaml Outdated Show resolved Hide resolved
@VanillaSpoon VanillaSpoon requested a review from dimakis June 16, 2023 15:28
@dimakis dimakis requested a review from astefanutti June 19, 2023 09:36
@VanillaSpoon VanillaSpoon force-pushed the pull_secrets branch 2 times, most recently from 201105f to e74f6d1 Compare June 21, 2023 15:12
@VanillaSpoon VanillaSpoon marked this pull request as ready for review June 21, 2023 15:23
astefanutti
astefanutti reviewed Jun 22, 2023
View reviewed changes
tests/unit_test.py Outdated Show resolved Hide resolved
@VanillaSpoon VanillaSpoon force-pushed the pull_secrets branch 2 times, most recently from 700d2b6 to cead100 Compare June 22, 2023 13:43
astefanutti
astefanutti approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelClifford
Copy link
Collaborator

@VanillaSpoon Looks good! Thanks for the PR.

The only comment that I have is that I don't think the *.html files are needed in here. We typically update all the docs at once prior to a new release.

@VanillaSpoon
Copy link
Contributor Author

Thanks @MichaelClifford,
I have removed the commit for the docs on this pr.

KPostOffice
KPostOffice reviewed Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my cluster 👍🏻

One suggestion

src/codeflare_sdk/utils/generate_yaml.py Outdated Show resolved Hide resolved
dimakis
dimakis approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

great work @VanillaSpoon 🚀

@dimakis dimakis merged commit 52b94c4 into project-codeflare:main Jun 29, 2023
@VanillaSpoon VanillaSpoon self-assigned this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice left review comments

@dimakis dimakis dimakis approved these changes

@astefanutti astefanutti astefanutti approved these changes

@MichaelClifford MichaelClifford MichaelClifford left review comments

Assignees

@VanillaSpoon VanillaSpoon

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for image pull secrets for Ray Cluster images
5 participants
@VanillaSpoon @MichaelClifford @astefanutti @KPostOffice @dimakis