Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounting problem for speciation followed by extinction #63

Closed
wibach opened this issue Dec 5, 2022 · 6 comments
Closed

accounting problem for speciation followed by extinction #63

wibach opened this issue Dec 5, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@wibach
Copy link

wibach commented Dec 5, 2022

I found an issue where a species dies at timestep t, and speciates at t+1 (t-1 in backwards counting steps).
@ohagen
Copy link
Member

ohagen commented Dec 6, 2022 •
edited
Loading

Hi Mine,
Can you specify? I guess you already talked with Benji @benj919 and Alex about this?
Would be good to have a MRE .
Feel free to e-mail or zoom me anytime.
Cheers

@ohagen
Copy link
Member

ohagen commented Dec 6, 2022

Closing for the moment as we still lack an MRE and/or further information is necessary.

@ohagen ohagen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@benj919
Copy link
Collaborator

benj919 commented Dec 6, 2022 •
edited
Loading

I'll take a look at this.

Species 1 dies at 638, speciates 4 in 637
Species 6 dies at 588, speciates 23 in 587

phy.nex.txt
phy.txt

@benj919 benj919 reopened this Dec 6, 2022
@ohagen
Copy link
Member

ohagen commented Dec 6, 2022

Thanks Benji!
Let me know if you need a hand looking into it. Curious to hear more.

@benj919 benj919 added the bug Something isn't working label Dec 7, 2022
@ohagen
Copy link
Member

ohagen commented Apr 12, 2023

This is only an accounting problem, where it might seams so when a species goes extinct in the same time step as it speciate.

@benj919 did you manage to add the -1 to the counter?

@ohagen ohagen changed the title Dead species can speciate accounting problem for speciation followed by extinction Oct 29, 2023
benj919 added a commit that referenced this issue Nov 13, 2023
@benj919
fix #63, we update the extinction time at the end of the timestep to …
3ac59d2 
…ti-1 -> any species alive at the end of a timestep will be counted to be alive at the beginning of the next one
benj919 added a commit that referenced this issue Nov 13, 2023
@benj919
fix #63, we update the extinction time at the end of the timestep to …
a26c6be 
…ti-1 -> any species alive at the end of a timestep will be counted to be alive at the beginning of the next one
@ohagen ohagen reopened this Nov 17, 2023
@ohagen ohagen closed this as completed Nov 17, 2023
@ohagen
Copy link
Member

ohagen commented Nov 17, 2023

short re-opening referent to the possible unnecessary files.

@benj919 benj919 mentioned this issue Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benj919 @ohagen @wibach