Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #54: add > before the closing fence to match the opening fence #55

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Fix #54: add > before the closing fence to match the opening fence #55

merged 2 commits into from
Oct 11, 2021

Conversation

yihui
Copy link
Contributor

@yihui yihui commented Oct 6, 2021 •
edited
Loading

If the opening fence of a code chunk is >```, the closing fence should be the same.

More info: yihui/knitr#2057

@yihui yihui changed the title Fix #54: add > before the closing fence to match the opening fence > Fix #54: add > before the closing fence ` to match the opening fence > ` Oct 6, 2021
@yihui yihui changed the title Fix #54: add > before the closing fence ` to match the opening fence > ` Fix #54: add > before the closing fence \\\ to match the opening fence > ```` Oct 6, 2021
@yihui yihui changed the title Fix #54: add > before the closing fence \\\ to match the opening fence > ```` Fix #54: add > before the closing fence to match the opening fence Oct 6, 2021
@benj919
Copy link
Collaborator

benj919 commented Oct 6, 2021

Thank you for this fix and the pull request. We'll check it out and most probably merge it soon.

ohagen added a commit that referenced this pull request Oct 6, 2021
@ohagen
Update create_config.Rmd
58a25e2 
fix #54 based on fix #55
@yihui
Copy link
Contributor Author

yihui commented Oct 7, 2021

@ohagen If you don't mind, you may just merge this PR (to save you some time). Your commit 58a25e2 is not enough to fix the Github action error. You'll have to also apply my commit 1d67011 if you intend to fix #54 in your PR #52 instead.

@yihui
Copy link
Contributor Author

yihui commented Oct 7, 2021

Or I can also send this PR to the development branch, so you can merge it to that branch instead of master if you prefer.

@ohagen
Copy link
Member

ohagen commented Oct 8, 2021

@yihui Thanks! Thank you. benji will merge your PR and roll back my changes. Thank you very much. The dev and master will be merged as well since we will then send a new package version to CRAN.
Thanks again @yihui

@benj919 benj919 merged commit 080f78f into project-gen3sis:master Oct 11, 2021
@yihui yihui deleted the patch-1 branch October 12, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihui @benj919 @ohagen