Fix typo in design_landscape vignette

[mmore500]

Appears to have been introduced by an erroneous renaming? 130bc18?diff=unified&w=0#r134004700

[benj919]

Hi @mmore500
Thank you for this pull request.

I agree there's an obvious error here:

temp_dataframe[counting,2+timestep]<-temp_dataframe[x,y,timestep]
Error in temp_dataframe[x, y, timestep] : incorrect number of dimensions

Though running your fix does not solve that:

temp_dataframe[counting,2+timestep]<-temp_matrix[x,y,timestep]
Error: object 'temp_matrix' not found

I think the fixes you are looking for are:

temp_dataframe[counting,2+timestep]<-temp_array[x,y,timestep]
prec_dataframe[counting,2+timestep]<-prec_array[x,y,timestep]

Though to be honest I think the whole thing could be done in one pass without copying the values around 🤷‍♂️

I'll close this pull request,thanks again for taking the time to look into this and open the pull request. Please let us know if you intend to open a new one with a fix?

cheers

[mmore500]

Happy to open an alternate PR with `_array` instead of `_matrix`, would that be helpful?

[benj919]

That would work, yes. If you do so please do a quick check (without adding that to the pull request) and plot the resulting rasters on line 136/137 to make sure that there's actually something put into the rasters.

Thanks again for your efforts 👍