Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tailtip widget by default by explicitly overriding picicli jline3 #469

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Sep 17, 2020

This explicitly enables tailtip support for the console interface. To do that I have had to inline a lot of picocli-jline3 support until remkop/picocli#1175 is fixed (found during discussions on jline/jline3#571 ).

If this is ok , I'll add a separate internal tracker to remove the override code (the second commit) once picocli 4.6 is out.

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #469 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #469      +/-   ##
===========================================
- Coverage      5.62%   5.50%   -0.12%     
  Complexity      106     106              
===========================================
  Files           134     134              
  Lines          5035    5142     +107     
  Branches        468     493      +25     
===========================================
  Hits            283     283              
- Misses         4733    4840     +107     
  Partials         19      19              
Impacted Files Coverage Δ Complexity Δ
cli/src/main/java/org/jboss/pnc/bacon/cli/App.java 16.02% <0.00%> (-23.17%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a8ffb...e4c3962. Read the comment docs.

@thescouser89
Copy link
Contributor

To be honest, I have no idea this tailtip thing existed and what the code does. But I did checkout the commit and built it and it looks really cool.

Feel free to create an internal tracker to remove the override code when picocli 4.6 is out. And thanks for the commit! :)

@thescouser89 thescouser89 merged commit 9d368fe into project-ncl:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants