Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

"atomic ps" errors after system container is uninstalled #495

Closed
yuqi-zhang opened this issue Jul 21, 2016 · 0 comments
Closed

"atomic ps" errors after system container is uninstalled #495

yuqi-zhang opened this issue Jul 21, 2016 · 0 comments

Comments

@yuqi-zhang
Copy link
Contributor

Mostly as a note for @giuseppe, when a system container is successfully uninstalled, and the user tries to "atomic ps", it will return the error:

[Errno 2] No such file or directory: '/var/lib/containers/atomic/CONTAINER/info'

At a glance this seems to be due to a dangling symlink of CONTAINER still existing in /var/lib/containers/atomic/

As an addon to this, I noticed that when an install fails, many time symlinks/created directories are not cleaned up. If the user tries to install again they would run into "a container CONTAINER is already present". Then the user would have to atomic uninstall on the failed container (which will clean up files but error while doing so) before re-installing. This is not a big issue but it just seems like a hassle and could confuse newer users.

giuseppe added a commit to giuseppe/atomic that referenced this issue Jul 22, 2016
Use `os.path.lexists' to verify its presence.  Delete the symlink before
the deployments, so that the container doesn't look installed while its
being deleted.

Closes: projectatomic#495

Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe added a commit to giuseppe/atomic that referenced this issue Jul 22, 2016
Use `os.path.lexists' to verify its presence.  Delete the symlink before
the deployments, so that the container doesn't look installed while its
being deleted.

Closes: projectatomic#495

Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe added a commit to giuseppe/atomic that referenced this issue Jul 25, 2016
Use `os.path.lexists' to verify its presence.  Delete the symlink before
the deployments, so that the container doesn't look installed while its
being deleted.

Closes: projectatomic#495

Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe added a commit to giuseppe/atomic that referenced this issue Jul 26, 2016
Use `os.path.lexists' to verify its presence.  Delete the symlink before
the deployments, so that the container doesn't look installed while its
being deleted.

Closes: projectatomic#495

Signed-off-by: Giuseppe Scrivano <[email protected]>
rh-atomic-bot pushed a commit that referenced this issue Jul 26, 2016
 mI3fTo4Z5yDKHQ1zpVaqjMRuDxMe94uRhfii4RIQuXpeFj/f4n1TZ/j32mVk8EwB
 UszEe6Tx/nzFXoW7FD5gomf1zvlxYwPRxJGJ6lzeNdi5ShhoeUelD6qWibCK19DC
 cZSEAklCzwgF8WpSTK6ABSiffVTLiug5K7mK2bsYd2JcxaZmXv3VhiOW3Q+zxMT9
 U/ocVoJRayr45Z/6UWUnxhwqIq9djFDMu9E4RootRZezp+eSBm5qE/iMFhYLTxMw
 hRtjlhE/jMM7ZAi/w3zFblvhjPfdra1Nv5TxVkCEc+3ruFKCpHKOiLiRd6YizDJX
 AZR7Z4+4poqA+9OrsEJ8z/r1DuF+XpxsFYxT+mnCnsLhkLsUPNka0thLTWh7cWy3
 vf9zmbJCPwc+wrfoonlJphdX8FO6s2JkpOuCN/0eHLRHFc2UgaMY1Jwx2+DfLgkV
 3ncUlNBw/zWYUvB3UiAYVFf+LarAIwrSGI0EMQez8OoXxU+llRn6Yx1fGsCg68/G
 uuCeIZgN760lqb6JCfRZQxYhmnWElQrw7b3GPgRNJ5GBL0zPE0VP47WUaW4bgS2D
 TNxeMIydshqOj6mAuQILzI5Yrn9+1wExGPiP8tUlJC+v02SA9BszRq6X0Q400Dzk
 MllAi/MhHJVu2TIjdGF0
 =qCpS
 -----END PGP SIGNATURE-----

syscontainers: do not leave broken symlink on uninstall

Use `os.path.lexists' to verify its presence.  Delete the symlink before
the deployments, so that the container doesn't look installed while its
being deleted.

Closes: #495

Signed-off-by: Giuseppe Scrivano <[email protected]>

Closes: #497
Approved by: rhatdan
giuseppe added a commit to giuseppe/atomic that referenced this issue Jul 26, 2016
Use `os.path.lexists' to verify its presence.  Delete the symlink before
the deployments, so that the container doesn't look installed while its
being deleted.

Closes: projectatomic#495

Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe added a commit to giuseppe/atomic that referenced this issue Jul 26, 2016
Use `os.path.lexists' to verify its presence.  Delete the symlink before
the deployments, so that the container doesn't look installed while its
being deleted.

Closes: projectatomic#495

Signed-off-by: Giuseppe Scrivano <[email protected]>

Closes: projectatomic#497
Approved by: jlebon
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant