[merged] Cleanup temporary mount point upon failure #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Nov 2, 2016
|
|
||
| mkfifo $PIPE1 | ||
| mkfifo $PIPE2 | ||
| mount -o bind $TEMPDIR $TEMPDIR | ||
| unshare -m /usr/lib/docker-storage-setup/dss-child-read-write $PIPE1 $PIPE2 & |
There was a problem hiding this comment.
We could rely on the kernel to umount if we did the mount inside the unshare, no?
There was a problem hiding this comment.
That's a good point. We should not have to do mounting in host mount namespace. We should be able to create new mount namespace, do the mount and then signal to parent that try to remove directory from host mount namespace.
Only extra overhead will be that we will have to pass the path to the tmp directory to child process. That should be fine.
Will try it.
Do the bind mount in child mount namespace. That way it will automaitcally get cleaned up as child exits. Also create pipes after making sure child process script exists. Signed-off-by: Vivek Goyal <[email protected]>
|
@cgwalters PTAL. Now I am creating bind mount inside child process mount namespace. |
|
LGTM |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162
platform_supports_deferred_deletion() mounts tempdir and then can exit
due to error conditions and never unmount that tempdir. Do an unmount
during exit to do the cleanup.
Also make a error check little early. First do the check and then
create pipes and mount point.
Signed-off-by: Vivek Goyal [email protected]