Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checkConflictingNodes() processing to avoid excessive queries on startup #871

Closed
robbrockbank opened this issue Jun 23, 2017 · 3 comments
Assignees
Milestone

Comments

@robbrockbank
Copy link
Contributor

robbrockbank commented Jun 23, 2017

During calico/node startup, the startup script performs a check for conflicting IP addresses configured across the cluster of nodes.

For large deployments this can take lead to a large number of queries if all nodes are restarting at the same time.

We should either just remove this check completely (it's not strictly required), perform a lazy validation, add a validation function in calicoctl (which you run anywhere once), or only perform this validation when the node IP addresses change.

@robbrockbank robbrockbank added this to the Calico v2.4.0? milestone Jun 23, 2017
@caseydavenport
Copy link
Member

After discussing with @robbrockbank, we think the following is a good solution:

  1. Only perform the IP validation check when startup.go thinks the IP address has changed.
  2. Add an option to disable the IP validation check entirely (e.g. DISABLE_NODE_IP_CHECK=true)

@robbrockbank
Copy link
Contributor Author

Key thing to add is that it is the Nodes().List() operation that is heavy-weight so that is the operation that should be avoided unless necessary.

@heschlie
Copy link
Contributor

Resolved in #915

caseydavenport pushed a commit that referenced this issue Dec 14, 2021
…-master

[master] Semaphore Auto Pin Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants