Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.1 and v2.6.5 RNs also addresses feedback on v3.0.0 RN #1564

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

emanic
Copy link
Contributor

@emanic emanic commented Dec 22, 2017

Description

  • v3.0.1 and v2.6.5 Release Notes, also incorporates suggestions from @lxpollitt

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@emanic emanic requested a review from bcreane December 22, 2017 21:19
@tmjd
Copy link
Member

tmjd commented Dec 22, 2017

If #1563 is being dropped in favor of this one, there are several things that I think should be added to this PR. Specifically the big warnings.

I guess the content is present but I don't feel like it is emphasized enough.

download_url: https://github.com/projectcalico/calicoctl/releases/download/v2.0.0/calicoctl
calico/node:
version: v3.0.1
url: https://github.com/projectcalico/calico/releases/tag/v3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be v3.0.1 (I think that's my mistake)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

- title: v3.0.0
note: |
21 December 2017

> **Important**: Due to a known issue in this release that can cause brief losses
> of connectivty after upgrading from v2.6.4 when using the etcd datastore, this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

connectivity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooops ok

Copy link
Contributor

@bcreane bcreane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of corrections ... otherwise looks good.
hopefully @lxpollitt gets a chance to review.
note that we will plan on updating the release notes after we cut the release to get rid of unneeded components, as discussed on slack.

tmjd
tmjd previously requested changes Dec 22, 2017

- You must upgrade to Calico v2.6.5 before you can upgrade to v3.0.1.

- Those accessing the etcd datastore directly must complete a one-time migration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like it is for users that access the etcd datastore directly. I think this should be Calico deployments using the etcd datastore must complete a one-time migration. or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK


- Those accessing the etcd datastore directly must complete a one-time migration.

- You must convert any customized manifests via `calicoctl convert` before you can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, this could be interpreted as Kubernetes manifests too. Only Calico manifests, that use the Calico resource models, should be converted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks, good info.

@emanic emanic changed the title v3.0.1 RN draft also addresses feedback on v3.0.0 RN v3.0.1 and v2.6.5 RNs also addresses feedback on v3.0.0 RN Dec 22, 2017
@bcreane bcreane dismissed tmjd’s stale review December 22, 2017 22:02

comments addressed

Copy link
Contributor

@bcreane bcreane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -570,8 +906,8 @@ v2.6:
url: https://github.com/projectcalico/calicoctl/releases/tag/v1.6.1
download_url: https://github.com/projectcalico/calicoctl/releases/download/v1.6.1/calicoctl
calico/node:
version: v2.6.2
url: https://github.com/projectcalico/calico/releases/tag/v2.6.2
version: v2.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change in 2.6.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't change. only changes should be to v2.6.5 and v3.0.1, plus a RN-only change to v3.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this was an error

version: v2.6.2
url: https://github.com/projectcalico/calico/releases/tag/v2.6.2
version: v2.6.1
url: https://github.com/projectcalico/calico/releases/tag/v2.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't right ... we should not have any changes to v2.6.2.

This was referenced Dec 22, 2017
@bcreane bcreane merged commit 4391be4 into projectcalico:master Dec 22, 2017
@emanic emanic deleted the v3.0.1-rn branch January 17, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants