-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.1 and v2.6.5 RNs also addresses feedback on v3.0.0 RN #1564
Conversation
If #1563 is being dropped in favor of this one, there are several things that I think should be added to this PR. Specifically the big warnings. I guess the content is present but I don't feel like it is emphasized enough. |
_data/versions.yml
Outdated
download_url: https://github.com/projectcalico/calicoctl/releases/download/v2.0.0/calicoctl | ||
calico/node: | ||
version: v3.0.1 | ||
url: https://github.com/projectcalico/calico/releases/tag/v3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be v3.0.1 (I think that's my mistake)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
_data/versions.yml
Outdated
- title: v3.0.0 | ||
note: | | ||
21 December 2017 | ||
|
||
> **Important**: Due to a known issue in this release that can cause brief losses | ||
> of connectivty after upgrading from v2.6.4 when using the etcd datastore, this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connectivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooooops ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of corrections ... otherwise looks good.
hopefully @lxpollitt gets a chance to review.
note that we will plan on updating the release notes after we cut the release to get rid of unneeded components, as discussed on slack.
_data/versions.yml
Outdated
|
||
- You must upgrade to Calico v2.6.5 before you can upgrade to v3.0.1. | ||
|
||
- Those accessing the etcd datastore directly must complete a one-time migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like it is for users that access the etcd datastore directly. I think this should be Calico deployments using the etcd datastore must complete a one-time migration.
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
_data/versions.yml
Outdated
|
||
- Those accessing the etcd datastore directly must complete a one-time migration. | ||
|
||
- You must convert any customized manifests via `calicoctl convert` before you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect, this could be interpreted as Kubernetes manifests too. Only Calico manifests, that use the Calico resource models, should be converted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks, good info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
_data/versions.yml
Outdated
@@ -570,8 +906,8 @@ v2.6: | |||
url: https://github.com/projectcalico/calicoctl/releases/tag/v1.6.1 | |||
download_url: https://github.com/projectcalico/calicoctl/releases/download/v1.6.1/calicoctl | |||
calico/node: | |||
version: v2.6.2 | |||
url: https://github.com/projectcalico/calico/releases/tag/v2.6.2 | |||
version: v2.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change in 2.6.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcreane ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldn't change. only changes should be to v2.6.5 and v3.0.1, plus a RN-only change to v3.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK this was an error
_data/versions.yml
Outdated
version: v2.6.2 | ||
url: https://github.com/projectcalico/calico/releases/tag/v2.6.2 | ||
version: v2.6.1 | ||
url: https://github.com/projectcalico/calico/releases/tag/v2.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't right ... we should not have any changes to v2.6.2.
Description
Todos
Release Note