-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure manifests always auto-detect BGP IP addresses #1588
Ensure manifests always auto-detect BGP IP addresses #1588
Conversation
I think we want to port this back to v3.0 and potentially even v2.6 as well. Input welcome :) |
Only thought is that |
@@ -243,9 +243,6 @@ spec: | |||
valueFrom: | |||
fieldRef: | |||
fieldPath: spec.nodeName | |||
# No IP address needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use autodetect
here? If we don't then we won't benefit from the fix in #1589 when IPs change (since we deliberately exclude the IP=""
case in that patch). Looks like, if IP
is not set then we do a single autodetection anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this is the policy-only manifest, which shouldn't care about the BGP IP address anyway.
The code in #1589 won't even get hit because we set CALICO_NETWORKING_BACKEND=none
in this manifest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK, that makes sense, was a bit tunnel-visioned on the code I was reviewing.
@fasaxc it doesn't exacerbate it really, just makes it more visible to the user, right? Without this, IPs will change and nodes will try to bind to the wrong (old) one. With this, IPs will change and calico will notice, but be unable to set the new IP. I think this should go into master and v3.0, and the fix will go into v3.0.2 |
I guess that makes sense, would be nice to have the fix available though if we're going to make the problem more visible. |
Description
Fixes #1470
Todos
Release Note