Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rev bird to 0.3.2 and add IPIP test to check route scan processing works correctly #1625

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Rev bird to 0.3.2 and add IPIP test to check route scan processing works correctly #1625

merged 1 commit into from
Jan 22, 2018

Conversation

robbrockbank
Copy link
Contributor

@robbrockbank robbrockbank commented Jan 19, 2018 •
edited by caseydavenport
Loading

Description

v2.6.x cherrypick of #1624

I have not included the go-bgp backend in the test because that also seems to be broken. I've raised an issue for that against go bgp.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix a route scan issue where upon startup bird did not spot that a tunneled route needed to be updated to be non-tunneled.

@robbrockbank robbrockbank changed the title Rev bird to 0.3.2 and add IPIP test to check route scan processing works correctly [WIP] Rev bird to 0.3.2 and add IPIP test to check route scan processing works correctly Jan 19, 2018
@robbrockbank robbrockbank added this to the Calico v2.6.7 milestone Jan 22, 2018
@robbrockbank robbrockbank force-pushed the ipip-scan-test branch 2 times, most recently from f8cf7a1 to fa291de Compare January 22, 2018 18:25
@robbrockbank robbrockbank mentioned this pull request Jan 22, 2018
Closed
caseydavenport
caseydavenport reviewed Jan 22, 2018
View reviewed changes
calico_node/tests/st/bgp/test_ipip.py Outdated
@@ -167,6 +170,88 @@ def test_ipip_addr_assigned(self):
self.pool_action(host, "delete", ipv4_pool, True)
self.assert_tunl_ip(host, new_ipv4_pool)

@parameterized.expand([
('bird',),
#('gobgp',),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could ya add a link to the issue here so future explorers have somewhere to go?

caseydavenport
caseydavenport approved these changes Jan 22, 2018
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, one comment about a comment

@robbrockbank robbrockbank changed the title [WIP] Rev bird to 0.3.2 and add IPIP test to check route scan processing works correctly Rev bird to 0.3.2 and add IPIP test to check route scan processing works correctly Jan 22, 2018
@robbrockbank robbrockbank merged commit 0f0e218 into projectcalico:v2.6.x-series Jan 22, 2018
@robbrockbank robbrockbank deleted the ipip-scan-test branch January 22, 2018 21:39
@robbrockbank robbrockbank mentioned this pull request Jan 22, 2018
Closed
@caseydavenport caseydavenport added the release-note-required Change has user-facing impact (no matter how small) label Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Milestone
Calico v2.6.7
Development

Successfully merging this pull request may close these issues.
2 participants
@robbrockbank @caseydavenport