[release-v3.28] Auto pick #9547: Remove CRDs from tigera-operator.yaml #9548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generation Update RBAC Fix OCP handling of manifests Remove operator CRDs as well Fix ocp.tgz Fix ocp.tgz Revert "remove get-operator-crds target from Makefile" This reverts commit 8d42815. Don't pull CRDs for ocp dir any more Remove adminnetworkpolicies crd from manifests/ocp fix get-operator-crds Makefile target Only use CRD bootstrapping on the operator for the OCP manifests Use conditions in the charts themselves instead of copying files Define OPERATOR_BRANCH=release-v1.36 in metadata.mk
coutinhop
added
release-note-required
caseydavenport
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #9547 on release-v3.28.
#9547: Remove CRDs from tigera-operator.yaml
Original PR Body below
Cherry pick of #9518 on release-v3.29.
#9518: Remove CRDs from tigera-operator.yaml
NOTE: partial cherry-pick, only the manifests used on OCP will have the CRDs removed and have the operator bootstrap CRDs.
Original PR Body below
Description
Trying this out. It removes the CRDs from tigera-operator.yaml to reduce the size of the manifest.
Instead, it configures the operator pod itself to create these CRDs on startup.
The main consequences I can see are:
custom-resources.yamlBut I think this is probably worth trying out.
Related issues/PRs
Fixes #9517
Requires: tigera/operator#3610
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.