ST GoBGP backend #1382
Closed
ST GoBGP backend #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on calico-bgp-daemon PR |
| @@ -62,3 +68,11 @@ def test_single_route_reflector(self): | |||
| workload_host2], | |||
| ip_pass_list=[workload_host1.ip, | |||
| workload_host2.ip]) | |||
|
|
|||
| @attr('slow') | |||
| def test_bird_route_reflector_cluster(self): | |||
There was a problem hiding this comment.
_cluster should probably just be _single
| self._test_single_route_reflector(backend='bird') | ||
|
|
||
| @attr('slow') | ||
| def test_gobgp_route_reflector_cluster(self): |
tests/st/bgp/test_global_peers.py
Outdated
| @@ -40,8 +39,8 @@ def test_global_peers(self): | |||
| additional_docker_options=ADDITIONAL_DOCKER_OPTIONS, | |||
There was a problem hiding this comment.
The ADDITIONAL_DOCKER_OPTIONS have been made part of the common code and removed from bgp.
Should now use CLUSTER_STORE_DOCKER_OPTIONS in docker_host.py
Signed-off-by: Wataru Ishida <[email protected]>
|
Reflected review comments and rebased on the master. projectcalico/calico-bgp-daemon#20 is needed to be merged to pass ST. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test GoBGP backend as well as BIRD.
PRs below needs to be merged before this PR.
projectcalico/libcalico#173
projectcalico/calico-bgp-daemon#8