Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report version and cluster type from datastore in version command #1687

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Jul 20, 2017

Description

As title says.
Also fixed build date in the Makefile so it is set properly.

Todos

  • Documentation
  • Release note

Release Note

The calicoctl version command now includes the CalicoVersion and ClusterType as retrieved from the datastore.

@caseydavenport
Copy link
Member

We should update the reference doc: http://docs.projectcalico.org/v2.3/reference/calicoctl/commands/version

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

- Retrieve CalicoVersion and ClusterType from datastore and print with
  version command
- Fixed build date in Makefile
@tmjd tmjd force-pushed the report-cluster-type branch from 9ae3ee1 to 6511e14 Compare July 21, 2017 01:38
@tmjd tmjd merged commit 4d9109f into projectcalico:master Jul 21, 2017
@tmjd tmjd deleted the report-cluster-type branch July 21, 2017 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants