fix up docker filter for name=calico #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
added
cherry-pick-candidate
release-note-required
and removed
release-note-required
labels
caseydavenport
approved these changes
May 15, 2018
This was referenced May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
exec.Command()doesn't correctly handle escaped quotes. Consequently thedocker ps -a --filter "name=calico"command fails and we're not correctly listing relevant pods to examine for the diag. The fix is to remove the escaped quotes from the invocation.See https://stackoverflow.com/questions/26473674/double-quotes-escaping-in-golang-exec
Addresses issue: https://github.com/projectcalico/calicoctl/issues/1852
Todos
Release Note