Skip to content

Commit

Permalink
fixing up FVs
Browse files Browse the repository at this point in the history
  • Loading branch information
heschlie committed Dec 19, 2017
1 parent cbdfa83 commit e3109c7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion felix.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func main() {
const healthName = "felix-startup"

// Register this function as a reporter of liveness and readiness, with no timeout.
healthAggregator.RegisterReporter(healthName, &health.HealthReport{Live: true, Ready: false}, 0)
healthAggregator.RegisterReporter(healthName, &health.HealthReport{Live: true, Ready: true}, 0)

This comment has been minimized.

Copy link
@bcreane

bcreane Dec 20, 2017

Contributor

This doesn't look right since we're not yet ready (also Neil's version on master indicates Ready: false).

This comment has been minimized.

Copy link
@heschlie

This comment has been minimized.

Copy link
@bcreane

bcreane Dec 20, 2017

Contributor

I looked right at the true and saw false. You're right.

This comment has been minimized.

Copy link
@heschlie

heschlie Dec 20, 2017

Author Contributor

It's counter-intuitive, and I'm honestly not sure why we set it as such here, but we then send a report with the correct state of live: true, ready: false


// Make an initial report that says we're live but not yet ready.
healthAggregator.Report(healthName, &health.HealthReport{Live: true, Ready: false})
Expand Down
7 changes: 0 additions & 7 deletions fv/health_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,6 @@ var _ = Describe("health tests", func() {
// describeCommonFelixTests creates specs for Felix tests that are common between the
// two scenarios below (with and without Typha).
describeCommonFelixTests := func() {
Describe("with no per-node config in datastore", func() {
It("should not open port due to lack of config", func() {
// With no config, Felix won't even open the socket.
Consistently(felixReady, "5s", "1s").Should(BeErr())
})
})

Describe("with per-node config in datastore", func() {
BeforeEach(createPerNodeConfig)
AfterEach(removePerNodeConfig)
Expand Down

0 comments on commit e3109c7

Please sign in to comment.