Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.6.x: Report ready to kubernetes when the ready flag is false #1676

Merged
merged 2 commits into from
Dec 22, 2017
Merged

2.6.x: Report ready to kubernetes when the ready flag is false #1676

merged 2 commits into from
Dec 22, 2017

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Dec 22, 2017 •
edited
Loading

Description

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

None required

@fasaxc fasaxc changed the title [WiP] Report ready to kubernetes when the ready flag is explicitly set to f… Report ready to kubernetes when the ready flag is false Dec 22, 2017
@fasaxc fasaxc changed the title Report ready to kubernetes when the ready flag is false 2.6.x: Report ready to kubernetes when the ready flag is false Dec 22, 2017
@fasaxc fasaxc requested a review from nelljerram December 22, 2017 17:23
nelljerram
nelljerram approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@nelljerram nelljerram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fasaxc fasaxc merged commit c299bcc into projectcalico:2.6.x-series Dec 22, 2017
@fasaxc fasaxc deleted the 2.6.x-report-ready-when-not branch December 22, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelljerram nelljerram nelljerram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fasaxc @nelljerram