Support annotations on Policy objects #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
force-pushed
the
policy-annotations
branch
from
3173d59 to
6d674b8
Compare
caseydavenport
force-pushed
the
policy-annotations
branch
from
6d674b8 to
ee3ca3a
Compare
|
Still want to do a manual test of this, but @robbrockbank might want to take a first look. |
robbrockbank
approved these changes
Jul 10, 2017
caseydavenport
changed the title
|
@robbrockbank I have a particular use-case in mind for policy/profiles, but I would like to see it added to other things down the road. I'd really like to see us update to use a common metadata struct, but that's a longer discussion :) |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance Policy objects so that they support annotations. This will be useful for clients who want to track extra metadata about a given resource, or e.g. keep track of resources they specifically have created.
Once this is approved, I intend to do the same for Profiles.
Todos
Release Note