Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append --v2-config-only to all v2 grpc configs #138

Closed
davecheney opened this issue Jan 11, 2018 · 2 comments · Fixed by #167
Closed

Append --v2-config-only to all v2 grpc configs #138

davecheney opened this issue Jan 11, 2018 · 2 comments · Fixed by #167
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Milestone

Comments

@davecheney
Copy link
Contributor

When Envoy finds something invalid in the contour.yaml bootstrap config it falls back to parsing it as json which leads to confusing and hard to debug errors #136.

We can use --v2-config-only to force envoy to treat the file as yaml, and make the error easier to understand.

@davecheney davecheney modified the milestones: 0.3.0, 0.4.0 Jan 11, 2018
@davecheney davecheney added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 12, 2018
@cmaloney
Copy link

I'd be interested in trying to put together a simple patch to do this / get into contributing to contour

@davecheney
Copy link
Contributor Author

Sure thing. Go for it, but I probably won't look at it til 0.3 is released on Thursday as we're grinding down to code complete now.

The trick is to remember to run the render.sh script in the deployment/ directory to regenerate the various rbac and non rbac versions of the manifests. Don't worry if you get it wrong, CI will catch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants