Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GRPC server with envoy's go-control-plane #2134

Open
jpeach opened this issue Jan 22, 2020 · 16 comments
Open

Replace GRPC server with envoy's go-control-plane #2134

jpeach opened this issue Jan 22, 2020 · 16 comments
Assignees
@skriss
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
1.31.0

Comments

@jpeach
Copy link
Contributor

jpeach commented Jan 22, 2020

I looked ad go-control-plane a bit and we ought to be able to use it to replace our custom xDS code. The interfaces are a bit different, but we should be able to bind the DAG in without a lot of trouble. This likely gives us ADS support for free.

Related #1286
@jpeach
Copy link
Contributor Author

jpeach commented Jan 22, 2020

Note that this doesn't solve configuration snapshot consistency issues (see various issues in the go-control-plane repo).

@stevesloka stevesloka self-assigned this Jun 18, 2020
@stevesloka stevesloka mentioned this issue Jun 18, 2020
Closed
stevesloka added a commit to stevesloka/contour that referenced this issue Jun 22, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
ec78941 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 11, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
932aa91 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 16, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
d52b559 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 17, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
ada8044 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 17, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
eebb6e5 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 22, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
c9115c0 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 22, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
7ba50c8 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 22, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
7736882 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 27, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
580fd40 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 27, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
29946fd 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 28, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
25bc765 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 28, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
ec31372 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 28, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
b8f77f4 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 28, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
000b22d 
Fixes projectcontour#2134 by replacing the current XDS server implementation with the envoyproxy/go-control-plane impl.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 28, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
e5d6031 
Fixes projectcontour#2134 by implementing the Envoy go-control-plane to replace Contour's current custom xDS gRPC server.

The change utilizes snapshots as a way to represent a versioned point in time representation of the xDS
resources (RDS, CDS, EDS, LDS, SDS). When the dag is rebuilt or an endpoint changes, a new snapshot is
created with the updated caches for each xDS resource type.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Jul 29, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
401f886 
Fixes projectcontour#2134 by implementing the Envoy go-control-plane to replace Contour's current custom xDS gRPC server.

The change utilizes snapshots as a way to represent a versioned point in time representation of the xDS
resources (RDS, CDS, EDS, LDS, SDS). When the dag is rebuilt or an endpoint changes, a new snapshot is
created with the updated caches for each xDS resource type.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Aug 3, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
618d4fd 
Fixes projectcontour#2134 by implementing the Envoy go-control-plane to replace Contour's current custom xDS gRPC server.

The change utilizes snapshots as a way to represent a versioned point in time representation of the xDS
resources (RDS, CDS, EDS, LDS, SDS). When the dag is rebuilt or an endpoint changes, a new snapshot is
created with the updated caches for each xDS resource type.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Aug 3, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
b22f55a 
Fixes projectcontour#2134 by implementing the Envoy go-control-plane to replace Contour's current custom xDS gRPC server.

The change utilizes snapshots as a way to represent a versioned point in time representation of the xDS
resources (RDS, CDS, EDS, LDS, SDS). When the dag is rebuilt or an endpoint changes, a new snapshot is
created with the updated caches for each xDS resource type.

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Aug 4, 2020
@stevesloka
cmd/contour: replace current xds server with go-control-plane impl
cd50c4f 
Fixes projectcontour#2134 by implementing the Envoy go-control-plane to replace Contour's current custom xDS gRPC server.

The change utilizes snapshots as a way to represent a versioned point in time representation of the xDS
resources (RDS, CDS, EDS, LDS, SDS). When the dag is rebuilt or an endpoint changes, a new snapshot is
created with the updated caches for each xDS resource type.

Signed-off-by: Steve Sloka <[email protected]>
@jpeach jpeach mentioned this issue Aug 7, 2020
Closed
This was referenced Aug 10, 2020
Closed
Closed
This was referenced Aug 31, 2020
Closed
Merged
@skriss skriss added this to the 1.29.0 milestone Jan 29, 2024
@skriss
Copy link
Member

skriss commented Jan 30, 2024 •
edited
Loading

@davinci26 @clayton-gonsalves @izturn do any of you have non-production environments where you could try switching to using the go-control-plane xDS server instead of the legacy Contour impl and see if you encounter any problems? We've been running E2E's daily with it enabled with success but some more real-world testing (ideally looking at performance/scale in addition to correctness) would be great too before we consider flipping the default in Contour.

Specifically, this involves setting the following in the Contour config file:

server:
  xds-server-type: envoy

For reference here is a PR that changes the default to be envoy: #6146

@skriss
Copy link
Member

skriss commented Feb 13, 2024

@davinci26 @clayton-gonsalves @izturn (or anyone else) just a gentle nudge here, is this change something you could test in a non-prod environment?

@davinci26
Copy link
Contributor

@skriss sorry had this message on draft.

We are working on a bunch of items to improve the operational stability of Contour so we are not taking many upstream changes but I think we should be able to take it and test it out in a couple of weeks from now.

Does this work?

@skriss
Copy link
Member

skriss commented Feb 13, 2024

@skriss sorry had this message on draft.

We are working on a bunch of items to improve the operational stability of Contour so we are not taking many upstream changes but I think we should be able to take it and test it out in a couple of weeks from now.

Does this work?

That'd be great, thanks! We may make the change upstream soon-ish anyway to let CI start running regularly on it. It has already been running in our nightly tests and seems pretty stable.

@skriss
Copy link
Member

skriss commented Feb 13, 2024

selfnote: consider effects of Endpoint updates

@izturn
Copy link
Member

izturn commented Feb 22, 2024

@skriss, we have some non-prod environments, but we don't put a lot of payloads on them, we will try it later

@izturn
Copy link
Member

izturn commented Mar 1, 2024 •
edited
Loading

@skriss Based on our limited testing, everything is fine

skriss added a commit to skriss/contour that referenced this issue Mar 7, 2024
@skriss
change default xDS server to envoy
f2417c1 
The default xDS server implementation is
now `envoy`, i.e. the go-control-plane
implementation.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
skriss added a commit that referenced this issue Mar 7, 2024
@skriss
use a separate snapshot cache for EDS (#6250)
a740314 
- Triggers only EDS updates when endpoints change
- Does not trigger EDS updates when only non-endpoints change

Updates #2134.

Signed-off-by: Steve Kriss <[email protected]>
skriss added a commit to skriss/contour that referenced this issue Mar 7, 2024
@skriss
change default xDS server to envoy
126ce74 
The default xDS server implementation is
now `envoy`, i.e. the go-control-plane
implementation.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss mentioned this issue Mar 7, 2024
Merged
@sunjayBhatia sunjayBhatia assigned skriss and unassigned sunjayBhatia Mar 7, 2024
@skriss skriss moved this from Todo to In Progress in Contour Mar 7, 2024
skriss added a commit that referenced this issue Mar 12, 2024
@skriss
use envoy xDS server for featuretests (#6255)
bc301a1 
Updates #2134.

Signed-off-by: Steve Kriss <[email protected]>
skriss added a commit that referenced this issue Mar 12, 2024
@skriss
change default xDS server to envoy (#6146)
23a0297 
The default xDS server implementation is
now `envoy`, i.e. the go-control-plane
implementation.

Updates #2134.

Signed-off-by: Steve Kriss <[email protected]>
lubronzhan pushed a commit to lubronzhan/contour that referenced this issue Mar 13, 2024
@skriss @lubronzhan
use a separate snapshot cache for EDS (projectcontour#6250)
1fa4a50 
- Triggers only EDS updates when endpoints change
- Does not trigger EDS updates when only non-endpoints change

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
lubronzhan pushed a commit to lubronzhan/contour that referenced this issue Mar 13, 2024
@skriss @lubronzhan
use envoy xDS server for featuretests (projectcontour#6255)
22f3b26 
Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
lubronzhan pushed a commit to lubronzhan/contour that referenced this issue Mar 13, 2024
@skriss @lubronzhan
change default xDS server to envoy (projectcontour#6146)
ffbbc83 
The default xDS server implementation is
now `envoy`, i.e. the go-control-plane
implementation.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss modified the milestones: 1.29.0, 1.30.0 May 2, 2024
@skriss
Copy link
Member

skriss commented May 6, 2024

Remaining work here is to fully remove the Contour xDS server option and implementation, can plan to do this for the 1.31 release assuming no major issues post-1.29. release.

@skriss skriss modified the milestones: 1.30.0, 1.31.0 May 6, 2024
skriss added a commit to skriss/contour that referenced this issue Jul 17, 2024
@skriss
deprecate xDS server type field
978048a 
Fields are planned to be removed in the 1.31 release.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss mentioned this issue Jul 17, 2024
Merged
skriss added a commit that referenced this issue Jul 17, 2024
@skriss
deprecate xDS server type field (#6561)
49ede7e 
Fields are planned to be removed in the 1.31 release.

Updates #2134.

Signed-off-by: Steve Kriss <[email protected]>
geomacy pushed a commit to chaosbox/contour that referenced this issue Aug 22, 2024
@skriss
deprecate xDS server type field (projectcontour#6561)
c9d6233 
Fields are planned to be removed in the 1.31 release.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
SamMHD pushed a commit to SamMHD/contour that referenced this issue Sep 8, 2024
@skriss @SamMHD
deprecate xDS server type field (projectcontour#6561)
d3d61ed 
Fields are planned to be removed in the 1.31 release.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Saman Mahdanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Contour
Status: In Progress
Milestone
1.31.0
Development

Successfully merging a pull request may close this issue.

replace current xds server with go-control-plane impl stevesloka/contour
6 participants
@jpeach @stevesloka @skriss @sunjayBhatia @davinci26 @izturn