Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress V1: support for service backends #2137

Closed
jpeach opened this issue Jan 22, 2020 · 4 comments
Closed

Ingress V1: support for service backends #2137

jpeach opened this issue Jan 22, 2020 · 4 comments
Assignees
Labels
area/ingress Issues or PRs related to the Ingress API.

Comments

@jpeach
Copy link
Contributor

jpeach commented Jan 22, 2020

Support Ingress V1 IngressBackend changes. The IngressBackend gets a new ServiceBackend field to replace the service name and port. It probably doesn't make sense for Contour to support backends other than Services.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20190125-ingress-api-group.md#alternative-backend-types

@jpeach jpeach added the area/ingress Issues or PRs related to the Ingress API. label Jan 22, 2020
@jpeach jpeach mentioned this issue Jan 22, 2020
6 tasks
@sunjayBhatia sunjayBhatia self-assigned this Feb 10, 2021
@sunjayBhatia
Copy link
Member

The links in the issue are broken it seems, and the Ingress API seems to have settled on a more generic Resource backend: https://kubernetes.io/docs/concepts/services-networking/ingress/#resource-backend that is a TypedLocalObjectReference

@sunjayBhatia
Copy link
Member

How do we select a port to forward traffic to with a TypedLocalObjectReference? Use the first one? Add a cluster/route for each port?

See

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Feb 10, 2021

Updated KEP link: https://github.com/kubernetes/enhancements/tree/c14615cbf22c760fd0a6cbb4e962c66260c98463/keps/sig-network/1453-ingress-api#alternative-backend-types

Support for non-Service type Resources is implementation-specific. Implmentations MUST support Kubernetes Service. Support for other types is OPTIONAL.

idk, this makes me think Services are not intended to be supported in the generic Resource field, but I could see how it could be interpreted the other way

Also:

// Service references a Service as a Backend. This is specially
// called out as it is required to be supported AND to reduce
// verbosity.

@sunjayBhatia
Copy link
Member

sunjayBhatia commented Feb 10, 2021

Ah this is definitely already finished by #3266 which also converts v1beta1 Ingress to this format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ingress Issues or PRs related to the Ingress API.
Projects
None yet
Development

No branches or pull requests

2 participants