Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ingress V1 #2139

Closed
6 tasks done
jpeach opened this issue Jan 22, 2020 · 5 comments
Closed
6 tasks done

Support Ingress V1 #2139

jpeach opened this issue Jan 22, 2020 · 5 comments
Assignees
@sunjayBhatia
Labels
area/ingress Issues or PRs related to the Ingress API.

Comments

@jpeach
Copy link
Contributor

jpeach commented Jan 22, 2020 •
edited by sunjayBhatia
Loading

Kubernetes SIG Network is proposing a number of changes to the Ingress spec in order to graduate it to V1. Since Ingress is a standard common feature, we should evaluate whether Contour should support the V1 changes.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20190125-ingress-api-group.md
@jpeach jpeach added the area/ingress Issues or PRs related to the Ingress API. label Jan 22, 2020
@stevesloka stevesloka mentioned this issue Apr 17, 2020
Closed
@youngnick youngnick mentioned this issue Oct 20, 2020
Closed
@youngnick youngnick self-assigned this Nov 2, 2020
@youngnick
Copy link
Member

This issue is no longer blocked, and needs a design document. As it's related to the service-apis design, I'll get started on a design document for it as well.

@sunjayBhatia sunjayBhatia mentioned this issue Dec 10, 2020
Closed
@xaleeks xaleeks modified the milestone: 1.11.0 Dec 14, 2020
@youngnick
Copy link
Member

Sorry, I was unclear here. This work will need its own design document, separate to the service-apis one, but it will be similar, in that an IngressClass describes a Contour deployment and its associated Envoys - Contour will ignore the parameters field of the IngressClass, and will only use the oldest IngressClass that has a matching controller field. See the WIP PR #3213 in the GatewayClass section for inspiration.

@youngnick youngnick assigned sunjayBhatia and unassigned youngnick Feb 11, 2021
@sunjayBhatia sunjayBhatia mentioned this issue Feb 19, 2021
Merged
sunjayBhatia added a commit that referenced this issue Apr 26, 2021
@sunjayBhatia
Add support for wildcard hosts on Ingresses (#3381)
c7e1f44 
- Wildcard virtualhosts now allowed
- Envoy's virtualhost matching does not match on a single DNS label like
we want to implement
- For wildcard host routes, we add a header match rule
to match on the ":authority" header that is more strict and will only
match one DNS label wildcard
- Adds an integration test to validate behavior with a wildcard
certificate
- Passes ingress conformance tests for wildcards
- Adds the "regex" header match strategy (only internal for now)
- Ensure regex header matches are sorted correctly (after exact, before
contains matches)

Fixes #2138
Updates #2139

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia
Copy link
Member

sunjayBhatia commented Apr 27, 2021 •
edited
Loading

Not sure if the last step needs to be done as part of this or if we can call it pretty much done, all the ingress conformance tests are passing but flaky in CI/locally

Should we call it done or move it to 1.16?

@skriss
Copy link
Member

skriss commented Apr 27, 2021

Personally I'd call this one done and just leave the conformance issue open separately.

@sunjayBhatia
Copy link
Member

Removed the ingress conformance tests item, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunjayBhatia sunjayBhatia

Labels
area/ingress Issues or PRs related to the Ingress API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jpeach @skriss @sunjayBhatia @youngnick @xaleeks