Re-enable staticcheck #1044
Merged
Re-enable staticcheck #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds back staticcheck to the make check target. Updates: projectcontour#956 Signed-off-by: Rohan Vora <[email protected]>
stevesloka
suggested changes
Apr 25, 2019
| @@ -76,9 +76,6 @@ func (hn *HoldoffNotifier) OnChange(builder *dag.Builder) { | |||
| // counter holds an atomically incrementing counter. | |||
| type counter uint64 | |||
|
|
|||
| func (c *counter) get() uint64 { | |||
There was a problem hiding this comment.
The static check tool was complaining that this function was not being used. And since inc() and reset() themselves return the updated value, get() was not being used in the code.
There was a problem hiding this comment.
Ohh ok, sorry for that. I just read the diff and assumed. Thanks!
davecheney
reviewed
May 6, 2019
| @@ -2,7 +2,7 @@ PROJECT = contour | |||
| REGISTRY ?= gcr.io/heptio-images | |||
| IMAGE := $(REGISTRY)/$(PROJECT) | |||
| SRCDIRS := ./cmd ./internal ./apis | |||
| PKGS := $(shell go list -mod=readonly ./cmd/... ./internal/...) | |||
| PKGS := $(shell GO111MODULE=on go list -mod=readonly ./cmd/... ./internal/...) | |||
There was a problem hiding this comment.
This shouldn't be needed if you're running Go 1.12 or later. What error did this fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back staticcheck to make check target.
Updates: #956
Signed-off-by: Rohan Vora [email protected]