internal/dag: improve TLS secrets validation #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mattalberts |
youngnick
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
LGTM, I also agree with @davecheney that assert.Equal is your friend.
jpeach
force-pushed
the
issue/1697
branch
2 times, most recently
from
26589a2 to
de7a3f3
Compare
|
I rebased and updated the error messages for (IMHO) clarity. I'll leave this PR open for a while in case there is additional feedback. |
davecheney
approved these changes
Oct 18, 2019
Clarify the validation of the types of secrets that Contour will accept for TLS key+cert pairs and CA certificate bundles. Contour only accepts TLS key+cert pairs from secrets of type "kubernetes.io/tls". These secrets may contain an additional "ca.crt" field that stores the CA certificate bundle. Contour will otherwise accept CA certificate bundles from generic secrets (whose type is "Opaque" or is empty). Contour will ignore all other types of secrets. This fixes projectcontour#1697. Signed-off-by: James Peach <[email protected]>
|
having a small issue due to this change, see #2138 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the validation of the types of secrets that Contour
will accept for TLS key+cert pairs and CA certificate bundles.
Contour only accepts TLS key+cert pairs from secrets of type
"kubernetes.io/tls". These secrets may contain an additional
"ca.crt" field that stores the CA certificate bundle.
Contour will otherwise accept CA certificate bundles from
generic secrets (whose type is "Opaque" or is empty).
Contour will ignore all other types of secrets.
This fixes #1697.
Signed-off-by: James Peach [email protected]