internal/dag: Remove processing of service-apis GatewayClass/TCPRoute #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
requested review from
jpeach and
sunjayBhatia
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3279 +/- ##
==========================================
- Coverage 75.34% 75.26% -0.09%
==========================================
Files 98 98
Lines 6100 6068 -32
==========================================
- Hits 4596 4567 -29
+ Misses 1398 1394 -4
- Partials 106 107 +1
|
The service-apis design calls out that GatewayClasses & TCPRoutes won't be watched or processed by Contour the controller, so this removes them from processing since they won't be used. Updates projectcontour#3213 Signed-off-by: Steve Sloka <[email protected]>
stevesloka
force-pushed
the
removeGatewayClass
branch
from
a339314 to
6cbd6d5
Compare
stevesloka
changed the title
skriss
approved these changes
Jan 27, 2021
sunjayBhatia
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service-apis design calls out that GatewayClasses & TCPRoutes won't be watched
or processed by Contour the controller, so this removes them from processing since
they won't be used.
Updates #3213
Signed-off-by: Steve Sloka [email protected]