Add source ip hashing to RequestHash load balancing #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- must specify exactly one of header hashing policy or source ip hashing in a list element (otherwise ignored and warning generated) - cant specify to hash source ip multiple times (otherwise ignored and warning generated) Fixes: projectcontour#3703 Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
requested review from
tsaarni and
skriss
and removed request for
a team
sunjayBhatia
added
the
release-note/minor
Codecov Report
@@ Coverage Diff @@
## main #4141 +/- ##
==========================================
+ Coverage 74.64% 74.71% +0.06%
==========================================
Files 112 112
Lines 9722 9741 +19
==========================================
+ Hits 7257 7278 +21
+ Misses 2309 2307 -2
Partials 156 156
|
Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
commented
Oct 27, 2021
| // load balancing is desired. It must be the only hash option field set, | ||
| // otherwise this request hash policy object will be ignored. | ||
| // +optional | ||
| HashSourceIP bool `json:"hashSourceIP,omitempty"` |
There was a problem hiding this comment.
another option would be to put this in a "connection properties" struct to mirror Envoy in case there are other options that could be set in parallel to this in the future, but they do not exist and my guess is Envoy won't really be able to make other options that can be set in parallel to this, rather they would be separate policies in practice
youngnick
approved these changes
Oct 27, 2021
| @@ -0,0 +1,5 @@ | |||
| ### Source IP hash based load balancing | |||
There was a problem hiding this comment.
This changelog note is perfect, thanks @sunjayBhatia!
skriss
added a commit
to skriss/contour-operator
that referenced
this pull request
Nov 1, 2021
Updates operator per Contour changes: projectcontour/contour#4141 projectcontour/contour#4138 projectcontour/contour#4145 Signed-off-by: Steve Kriss <[email protected]>
stevesloka
pushed a commit
to projectcontour/contour-operator
that referenced
this pull request
Nov 2, 2021
Updates operator per Contour changes: projectcontour/contour#4141 projectcontour/contour#4138 projectcontour/contour#4145 Signed-off-by: Steve Kriss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a list element (otherwise ignored and warning generated)
warning generated)
Fixes: #3703