Gateway API: Fix for Listener/Route hostname isolation #6162

sunjayBhatia · 2024-02-07T18:44:38Z

Requests should be "isolated" to the most specific Listener and it's attached routes. This means our existing logic on finding intersecting route and Listener hostnames needs an update to factor in the other Listeners on a Gateway that the route in question may not actually be attached to.

Fix for conformance test: kubernetes-sigs/gateway-api#2669

kubernetes-sigs/gateway-api#2465 for spec

codecov · 2024-02-07T19:26:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (7530c06) to head (7573ae4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6162      +/-   ##
==========================================
+ Coverage   81.60%   81.62%   +0.01%     
==========================================
  Files         133      133              
  Lines       15842    15857      +15     
==========================================
+ Hits        12928    12943      +15     
  Misses       2620     2620              
  Partials      294      294

Files	Coverage Δ
internal/dag/gatewayapi_processor.go	`93.28% <100.00%> (+0.07%)`	⬆️

sunjayBhatia · 2024-02-07T19:47:18Z

Just a rough implementation whipped up, might need some improvements but for now we have something that works with the existing structure

github-actions · 2024-02-24T00:18:07Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-03-12T00:19:17Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-04-11T00:20:16Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-04-29T00:20:44Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

skriss · 2024-05-03T19:19:56Z

I think this impl makes sense? Is it passing the latest version of the upstream conformance (kubernetes-sigs/gateway-api#3047)?

sunjayBhatia · 2024-05-03T19:31:57Z

I think this impl makes sense? Is it passing the latest version of the upstream conformance (kubernetes-sigs/gateway-api#3047)?

it was before that PR got recreated, I'll rebase etc. on the version bump PR and see if it still does!

sunjayBhatia · 2024-05-03T19:49:53Z

I think this impl makes sense? Is it passing the latest version of the upstream conformance (kubernetes-sigs/gateway-api#3047)?

it was before that PR got recreated, I'll rebase etc. on the version bump PR and see if it still does!

passed in https://github.com/projectcontour/contour/actions/runs/8944042687/job/24570214238

skriss · 2024-05-03T20:09:28Z

Nice, LGTM

Requests should be "isolated" to the most specific Listener and it's attached routes. This means our existing logic on finding intersecting route and Listener hostnames needs an update to factor in the other Listeners on a Gateway that the route in question may not actually be attached to. Fix for conformance test: kubernetes-sigs/gateway-api#2669 kubernetes-sigs/gateway-api#2465 for spec Signed-off-by: Sunjay Bhatia <[email protected]>

Signed-off-by: Sunjay Bhatia <[email protected]>

…r#6162) Requests should be "isolated" to the most specific Listener and it's attached routes. This means our existing logic on finding intersecting route and Listener hostnames needs an update to factor in the other Listeners on a Gateway that the route in question may not actually be attached to. Fix for conformance test: kubernetes-sigs/gateway-api#2669 kubernetes-sigs/gateway-api#2465 for spec Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: Saman Mahdanian <[email protected]>

sunjayBhatia added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Feb 7, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2024

sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2024

github-actions bot closed this Apr 11, 2024

sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2024

sunjayBhatia reopened this Apr 12, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2024

sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2024

sunjayBhatia mentioned this pull request May 3, 2024

Bump gateway-api to v1.1.0 #6398

Merged

sunjayBhatia force-pushed the gw-listener-route-hostname-isolation branch from c294f1e to 082db77 Compare May 3, 2024 19:39

sunjayBhatia added 4 commits May 17, 2024 14:19

fix failing test

3b44bdd

Signed-off-by: Sunjay Bhatia <[email protected]>

comment

d51bfa0

Signed-off-by: Sunjay Bhatia <[email protected]>

reenable gateway listener isolation test

8831bce

Signed-off-by: Sunjay Bhatia <[email protected]>

sunjayBhatia force-pushed the gw-listener-route-hostname-isolation branch from 082db77 to 8831bce Compare May 17, 2024 18:19

changelog

7573ae4

Signed-off-by: Sunjay Bhatia <[email protected]>

sunjayBhatia marked this pull request as ready for review May 17, 2024 19:30

sunjayBhatia requested a review from a team as a code owner May 17, 2024 19:30

sunjayBhatia removed the request for review from a team May 17, 2024 19:30

sunjayBhatia requested review from tsaarni, skriss, a team, davinci26 and clayton-gonsalves and removed request for a team May 17, 2024 19:30

skriss approved these changes May 17, 2024

View reviewed changes

sunjayBhatia merged commit 3d1c646 into projectcontour:main May 17, 2024
27 checks passed

sunjayBhatia deleted the gw-listener-route-hostname-isolation branch May 17, 2024 20:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gateway API: Fix for Listener/Route hostname isolation #6162

Gateway API: Fix for Listener/Route hostname isolation #6162

sunjayBhatia commented Feb 7, 2024

codecov bot commented Feb 7, 2024 •

edited

Loading

sunjayBhatia commented Feb 7, 2024

github-actions bot commented Feb 24, 2024

github-actions bot commented Mar 12, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 29, 2024

skriss commented May 3, 2024

sunjayBhatia commented May 3, 2024

sunjayBhatia commented May 3, 2024

skriss commented May 3, 2024

Gateway API: Fix for Listener/Route hostname isolation #6162

Gateway API: Fix for Listener/Route hostname isolation #6162

Conversation

sunjayBhatia commented Feb 7, 2024

codecov bot commented Feb 7, 2024 • edited Loading

Codecov Report

sunjayBhatia commented Feb 7, 2024

github-actions bot commented Feb 24, 2024

github-actions bot commented Mar 12, 2024

github-actions bot commented Apr 11, 2024

github-actions bot commented Apr 29, 2024

skriss commented May 3, 2024

sunjayBhatia commented May 3, 2024

sunjayBhatia commented May 3, 2024

skriss commented May 3, 2024

codecov bot commented Feb 7, 2024 •

edited

Loading