shutdown manager: use filter on downstream_cx_active stats url #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a filter to prometheus stats url so that only the desired stats are returned. This improves the performance especially in clusters with high number of routes Signed-off-by: Ahmad Karimi <[email protected]>
therealak12
requested review from
tsaarni and
skriss
and removed request for
a team
sunjayBhatia
requested review from
a team,
davinci26 and
clayton-gonsalves
and removed request for
a team
Signed-off-by: Ahmad Karimi <[email protected]>
sunjayBhatia
added
the
release-note/small
sunjayBhatia
changed the title
Signed-off-by: Ahmad Karimi <[email protected]>
Signed-off-by: Ahmad Karimi <[email protected]>
Signed-off-by: Ahmad Karimi <[email protected]>
Signed-off-by: Ahmad Karimi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6523 +/- ##
=======================================
Coverage 81.64% 81.64%
=======================================
Files 133 133
Lines 15873 15873
=======================================
Hits 12959 12959
Misses 2620 2620
Partials 294 294
|
sunjayBhatia
approved these changes
Jun 20, 2024
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
…ctcontour#6523) Add a filter to prometheus stats url so that only the desired stats are returned. This improves the performance especially in clusters with high number of routes Signed-off-by: Ahmad Karimi <[email protected]> Signed-off-by: Saman Mahdanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a query param to the stats URL used in the shutdown-manager when waiting for the active connections to drain.
In clusters with a high number of routes (such as ours in Snapp with over 3000 routes), the
/stats/prometheusresponse size is above 80MBs. This makes rendering and fetching the URL take a few seconds.The introduced filter makes rendering faster and the response time shorter. Also, it reduces the time required for parsing and searching the response.
An example of the response when utilizing the filter:
Comparison of total request time before and after the filter: