Skip to content

Commit

Permalink
no need for browser.close()
Browse files Browse the repository at this point in the history
When the katana process exits, rod will automatically kill the browser process.
  • Loading branch information
zrquan authored and dwisiswant0 committed Jul 30, 2024
1 parent af010cf commit dfa7f80
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions pkg/engine/hybrid/hybrid.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ func New(options *types.CrawlerOptions) (*Crawler, error) {

// Close closes the crawler process
func (c *Crawler) Close() error {
if c.Options.Options.ChromeWSUrl == "" {
if err := c.browser.Close(); err != nil {
return err
}
}
if c.Options.Options.ChromeDataDir == "" {
if err := os.RemoveAll(c.tempDir); err != nil {
return err
Expand Down

0 comments on commit dfa7f80

Please sign in to comment.