Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to store http responses to file #177

Closed
vulnerablecodes opened this issue Nov 14, 2022 · 3 comments · Fixed by #185
Closed

Option to store http responses to file #177

vulnerablecodes opened this issue Nov 14, 2022 · 3 comments · Fixed by #185
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@vulnerablecodes
Copy link

vulnerablecodes commented Nov 14, 2022

An option to download all discovered files would be great. I know I can write a simple function to download all files via curl/wget etc, but having the option via katana itself would be ideal.

Based on - projectdiscovery/httpx#848

   -sr, -store-response              store http response to output directory
   -srd, -store-response-dir string  store http response to custom directory
@vulnerablecodes vulnerablecodes added the Type: Enhancement Most issues will probably ask for additions or changes. label Nov 14, 2022
@vulnerablecodes vulnerablecodes changed the title Option to download file would be great Option to download discovered files would be great Nov 14, 2022
@ehsandeep ehsandeep changed the title Option to download discovered files would be great Option to store http responses to file Nov 14, 2022
@ehsandeep ehsandeep added the Priority: Medium This issue may be useful, and needs some attention. label Nov 14, 2022
@tarunKoyalwar tarunKoyalwar linked a pull request Nov 27, 2022 that will close this issue
@wdahlenburg
Copy link
Collaborator

wdahlenburg commented Nov 29, 2022

@ehsandeep What are your thoughts on expanding this to allow for storing the HTTP request as well? In some cases I may just want the requests and in others the responses would be helpful. Perhaps they are stored as a pair, rather than the same file?

The current PR seems to drop the request body, which is a fixable issue on it's own, but I'd consider to be a bug.
image

The raw HTTP request is something that could be used by other tools, so long as it's "well-formed".

@ehsandeep
Copy link
Member

@wdahlenburg thanks for pointing this and good point on the request, I will create a follow-up ticket as this can be extended to get more controls like response, request + response, response body and response header.

@ehsandeep ehsandeep added the Status: In Progress This issue is being worked on, and has someone assigned. label Dec 6, 2022
@wdahlenburg
Copy link
Collaborator

@wdahlenburg thanks for pointing this and good point on the request, I will create a follow-up ticket as this can be extended to get more controls like response, request + response, response body and response header.

I wrote that comment before I messed with proxify, but is there a good reason for the output formats to be different between katana and proxify?

ehsandeep added a commit that referenced this issue Dec 8, 2022
* Added SECURITY.md

* Option to store http responses to file (#177)

* Remove debug output

* Add store response option

* update

* update sum

* update

* update

* fix test

* update output

Co-authored-by: Sandeep Singh <[email protected]>
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Priority: Medium This issue may be useful, and needs some attention. Status: In Progress This issue is being worked on, and has someone assigned. labels Dec 8, 2022
@ehsandeep ehsandeep added this to the Katana v0.0.3 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants