Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stored Response Path Not in JSON Output When Using "-sr" and "-jsonl" Flags #530

Closed
ErikOwen opened this issue Jul 21, 2023 · 1 comment · Fixed by #532
Closed

Stored Response Path Not in JSON Output When Using "-sr" and "-jsonl" Flags #530

ErikOwen opened this issue Jul 21, 2023 · 1 comment · Fixed by #532
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
katana v1.0.3

Comments

@ErikOwen
Copy link
Contributor

katana version:

v1.0.2

Current Behavior:

Katana is invoked with the "-jsonl" and "-sr" flags, and the path to the response body is not found in the JSON output, unlike httpx.

Expected Behavior:

A stored_response_path key is in the JSON output when "-sr" and "-json" flags are used, similar to httpx.

Steps To Reproduce:

  1. Run katana with "-jsonl" and "-sr" flags:
echo "https://www.google.com" | katana -d 1 -jsonl -sr
  1. Notice how there is no "stored_response_path" key in the JSON for where the response body was saved to in the filesystem
  2. Run httpx with `-json" and "-sr" flags:
echo "https://www.google.com" | httpx -json -sr
  1. Notice how there is a "stored_response_path" key in the JSON for where the response body was saved to in the filesystem

Anything else:

N/A
@ErikOwen ErikOwen added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 21, 2023
@ErikOwen ErikOwen mentioned this issue Jul 21, 2023
Merged
@ehsandeep ehsandeep added this to the katana v1.0.3 milestone Jul 31, 2023
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Aug 1, 2023
@ehsandeep
Copy link
Member

@ErikOwen now available in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
katana v1.0.3
Development

Successfully merging a pull request may close this issue.

Patch: Add the Stored Response Path as Key in JSON Output ErikOwen/katana
2 participants
@ErikOwen @ehsandeep