-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch: Add the Stored Response Path as Key in JSON Output #532
Merged
ehsandeep
merged 3 commits into
projectdiscovery:dev
from
ErikOwen:patch/add-stored-response-path-json-key
Aug 1, 2023
Merged
Patch: Add the Stored Response Path as Key in JSON Output #532
ehsandeep
merged 3 commits into
projectdiscovery:dev
from
ErikOwen:patch/add-stored-response-path-json-key
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse-path-json-key
ehsandeep
added
the
Type: Maintenance
Updating phrasing or wording to make things clearer or removing ambiguity.
label
Jul 31, 2023
tarunKoyalwar
approved these changes
Jul 31, 2023
ehsandeep
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikOwen, to keep it uniform as httpx, we can store the complete file path for stored_response_path
@ehsandeep - good catch. I have updated the
|
ehsandeep
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #530
Sample (notice the
stored_response_path
key at the bottom):