-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse the url and remove query #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- filter extensions `./katana -u https://www.youtube.com/ads/ -d 1 -ef js,css` - match extensions - `./katana -u https://www.youtube.com/ads/ -d 1 -em js,css`
ShubhamRasal
added
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Nov 16, 2022
ehsandeep
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./katana -u https://www.youtube.com/ads/ -d 2
https://www.youtube.com/about/brand-resources/
https://www.youtube.com/t/terms
https://www.youtube.com/ads/static/compiled/index.min.css?cache=73ab417
https://www.youtube.com/ads/static/compiled/globals.min.js?cache=6b767fc
https://www.youtube.com/ads/static/compiled/index.min.js?cache=e761d5a
https://www.youtube.com/create_channel?action_create_new_channel_redirect=true
http://studio.youtube.com
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x38 pc=0x100d550c0]
goroutine 12 [running]:
github.com/projectdiscovery/katana/pkg/utils/extensions.(*Validator).ValidatePath(0x14000352020, {0x14000183d40?, 0x50?})
/Users/geekboy/Github/katana/pkg/utils/extensions/extensions.go:49 +0x30
github.com/projectdiscovery/katana/pkg/navigation.Response.validatePath(...)
/Users/geekboy/Github/katana/pkg/navigation/response.go:48
github.com/projectdiscovery/katana/pkg/navigation.Response.AbsoluteURL({0x140010b2480, 0x2, 0x1400000f440, {0x140010e4000, 0x11ed1, 0x12000}, {0x1400010eea8, 0xf}, 0x1400028a1c0}, {0x14000183d40?, ...})
/Users/geekboy/Github/katana/pkg/navigation/response.go:31 +0xb0
github.com/projectdiscovery/katana/pkg/navigation.NewNavigationRequestURLFromResponse({0x14000183d40?, 0x100e9eadc?}, {0x14001129680, 0x43}, {0x100e9c4b3, 0x1}, {0x100e9eadc, 0x4}, {0x140010b2480, 0x2, ...})
/Users/geekboy/Github/katana/pkg/navigation/request.go:41 +0x9c
github.com/projectdiscovery/katana/pkg/engine/parser.bodyATagParser.func1(0x140006b3ca8?, 0x14001148e10)
/Users/geekboy/Github/katana/pkg/engine/parser/parser.go:143 +0x11c
github.com/PuerkitoBio/goquery.(*Selection).Each(0x14001148120, 0x140006b3cd0)
/Users/geekboy/go/pkg/mod/github.com/!puerkito!bio/[email protected]/iteration.go:10 +0x50
github.com/projectdiscovery/katana/pkg/engine/parser.bodyATagParser({0x140010b2480, 0x2, 0x1400000f440, {0x140010e4000, 0x11ed1, 0x12000}, {0x1400010eea8, 0xf}, 0x1400028a1c0}, 0x1400000e948)
/Users/geekboy/Github/katana/pkg/engine/parser/parser.go:140 +0xac
github.com/projectdiscovery/katana/pkg/engine/parser.ParseResponse({0x140010b2480, 0x2, 0x1400000f440, {0x140010e4000, 0x11ed1, 0x12000}, {0x1400010eea8, 0xf}, 0x1400028a1c0}, 0x1?)
/Users/geekboy/Github/katana/pkg/engine/parser/parser.go:80 +0x110
github.com/projectdiscovery/katana/pkg/engine/standard.(*Crawler).Crawl.func3()
/Users/geekboy/Github/katana/pkg/engine/standard/standard.go:127 +0x1a8
created by github.com/projectdiscovery/katana/pkg/engine/standard.(*Crawler).Crawl
/Users/geekboy/Github/katana/pkg/engine/standard/standard.go:109 +0x888
ehsandeep
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the shared crash info above.
ehsandeep
added
the
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
label
Nov 21, 2022
ehsandeep
approved these changes
Nov 21, 2022
Ice3man543
approved these changes
Nov 24, 2022
ehsandeep
removed
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter extensions
./katana -u https://www.youtube.com/ads/ -d 1 -ef js,css
match extensions
./katana -u https://www.youtube.com/ads/ -d 1 -em js,css