-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add katana as lib #205
Add katana as lib #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the implementation is correct - It puts in evidence that to properly use katana as a library, we would need the following:
-
OnResult
callback - Integration tests to verify the introduced example
I'd suggest covering at least the first point and tracking the second into another issue. What do you think?
Yeah.. I was thinking the same.. would add the callback as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - suggesting a target change (scanme.sh
). Maybe we should expose a more complex webapp for testing (cc @ehsandeep )
@Mzack9999 as of now replaced |
This PR adds