Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparent embedding of common code #373

Merged
merged 11 commits into from
Mar 23, 2023
Merged

Transparent embedding of common code #373

merged 11 commits into from
Mar 23, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Mar 21, 2023 •
edited
Loading

Closes #361

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Mar 21, 2023
@Mzack9999 Mzack9999 self-assigned this Mar 21, 2023
@Mzack9999 Mzack9999 linked an issue Mar 21, 2023 that may be closed by this pull request
Abstract crawler interface to reuse common functionalities #361
Closed
@Mzack9999 Mzack9999 added the Type: Optimization Increasing the performance/optimization. Not an issue, just something to consider. label Mar 22, 2023
@Mzack9999 Mzack9999 marked this pull request as ready for review March 22, 2023 15:06
tarunKoyalwar
tarunKoyalwar approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation lgtm !
suggested some minor improvements

pkg/engine/common/base.go Show resolved Hide resolved
pkg/engine/hybrid/crawl.go Outdated Show resolved Hide resolved
ehsandeep
ehsandeep approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mzack9999 merge conflict ^

@Mzack9999 Mzack9999 merged commit 96f362a into dev Mar 23, 2023
@Mzack9999 Mzack9999 deleted the issue-361-core-cleanup branch March 23, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. Type: Optimization Increasing the performance/optimization. Not an issue, just something to consider.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstract crawler interface to reuse common functionalities
3 participants
@Mzack9999 @ehsandeep @tarunKoyalwar